Opened 8 years ago

Closed 8 years ago

#337 closed enhancement (fixed)

pseudo3d enhancements & model load speedup

Reported by: gegorbet Owned by: gegorbet
Priority: normal Milestone: future
Component: ultrascan3 Version:
Keywords: review Cc:


Issues raised by D.Brent Halling at UTAustin:

  • Option for Z-axis of Percentage
    • option shows each point's percent of total concentration.
    • triggered by check box (e.g., "_Show Z as Percentage").
    • without "Automatic Plot Limits" checked, percents relative to maximum total concentration of all models.
    • with Auto, each model shows percents of its own total concentration.
  • Button / Dialog to edit selection list
    • way to avoid re-generating list when removing a list item
    • new "Delete Distribution(s)" button and resulting dialog
    • in dialog, list items may be removed.
  • Speed-up models list creation.
    • new procedure - get_model_desc_by_runID - would allow prescreening that could speed list appearance.
    • same Search fields could still be used to further pare down the initial models list.

Change History (3)

comment:1 Changed 8 years ago by gegorbet

Most of these ticket issues have been addressed and the code committed. There is now an option for the Z-axis to be Percent of Total Concentration. A Remove Distribution(s) button leads to a dialog where selected loaded models may be removed from the list, so that a reload of models is not necessary.

The hooks in the C++ code for model-load speedup by pre-filtering have been put in place. But the MySql stored procedures "get_model_desc_by_editID" and "get_noise_desc_by_editID" do not yet exist. Once they do, changes to speed up all model and noise loading can be easily enabled.

comment:2 Changed 8 years ago by gegorbet

  • Keywords review added
  • Status changed from new to assigned

With the commit of the new _by_editID procedures and changes to library code, loading of models and noises from databases with large model/noise counts has been considerably speeded up.

For Analysis programs with edit loading that explicitly (fematch) or implicitly (second_moment) load models and noises for optional noise subtraction, the speed-up is automatic. For programs that explicitly load model lists (pseudo3d_combine, ga_init), the creation of the model list can be speeded by selecting a Pre-Filter based on runID or editID beforehand.

This ticket is review-ready.

comment:3 Changed 8 years ago by demeler

  • Resolution set to fixed
  • Status changed from assigned to closed

Reviewed, works nicely for all items. Ticket will be closed.

Note: See TracTickets for help on using tickets.