Opened 8 years ago

Closed 8 years ago

#329 closed defect (fixed)

Fematch small bug - causes crash

Reported by: demeler Owned by: gegorbet
Priority: normal Milestone: future
Component: ultrascan3 Version:
Keywords: review Cc:

Description

There is a small bug in the fematch logic for the "Save" button. When you load a multi-triple run, load a model for the first triple, and then simulate the model, a bunch of screens pop up and the 'Save Data' button becomes active. If you switch then to another triple, the save button should become de-activated until the model for that triple has been simulated. At some point, the program can crash if the save data button is clicked even though there is no simulated data available yet for that newly selected triple (but the button is still activated). I think all of this can be fixed simply by making sure the save button gets de-activated when the user switches the triple. Only when "Simulate Model" for this triple has completed, should the "Save Data" button become active again. Otherwise, it is also not clear what triple the currently on-screen windows belong to when they are saved. Let's say you simulated data for cell 1, and then all windows show data for cell 1. Then you switch to cell 2 and all windows are still up, and when you click save - what exactly is saved? all currently visible windows and they get associated with cell 2? This seems ambiguous, but again, could be fixed by simply deactivting the save data button.

Change History (4)

comment:1 Changed 8 years ago by gegorbet

  • Owner changed from bdubbs to gegorbet
  • Status changed from new to assigned

comment:2 Changed 8 years ago by demeler

I have another suggestion here - to address the same problem in US2 earlier I actually force-close the result windows that are currently up at the screen when the user switches to another dataset. First, it clears up the screen from all this clutter, and secondly it makes it clear the user has to load/simulate another model before he can save again. So in addition of disabling the save button, all this screen clutter should be closed except the main screen.

comment:3 Changed 8 years ago by gegorbet

  • Keywords review added

Mods to us_fematch to disable buttons and clear plots at new triple select have been made and committed (US revision 1234). This ticket is review-ready.

comment:4 Changed 8 years ago by demeler

  • Resolution set to fixed
  • Status changed from assigned to closed

Reviewed - it works perfectly now. Will close the ticket.

Note: See TracTickets for help on using tickets.