Opened 8 years ago

Closed 8 years ago

#320 closed defect (fixed)

GA Init GUI logic incorrect for Monte Carlo distributions

Reported by: demeler Owned by: gegorbet
Priority: normal Milestone: future
Component: ultrascan3 Version:
Keywords: review Cc:


The behavior for Monte Carlo distributions is different then when 2dsa or ga individual distributions are loaded.

  1. When loading MC distributions from either GA or 2DSA, the program should disable the "Autoassign" button, since this logic would place way too many buckets in the initialization file. Here, the user should ALWAYS manually pick buckets.
  1. The "Check bucket overlap" button seems to be superfluous. The program will automatically check for bucket overlaps before saving a distro. I would just remove the button, or if you want to leave it, don't force the user to click on it first before activating the save button. If you leave it in the program, the button should be activated ONLY once 2 or more buckets have been defined.
  1. The Save button should be active whenever one or more bucket have been defined, regardless of the state of the check overlap button. It should also be active in the non-Monte Carlo distribution mode whenever the buckets have been autoassigned.
  1. Upon saving, a gadistro initialization file should be saved in ../results/<run_id_directory>/., but not in ../results/. This is also true for non-monte carlo distributions. A dialog could be presented that informs the user that the files were saved successfully in ../results/<run_id_directory>/run_id...<triple>.gadistro.dat. We could also consider to include the analysis type on which this gadistro was based (i.e., 2DSA-auto/manual, GA-auto/manual, GA-MC, 2DSA-MC - all MC by default have to be manual)
  1. If it is a Monte Carlo analysis, the ga_stats file should also be generated and include statistics computations for each bucket. This file should be saved in the same ../results/<run_id_directory>/. location.
  1. both ga_distro and ga_stats file should be accessible in the reporting system.

Change History (3)

comment:1 Changed 8 years ago by gegorbet

  • Keywords review added

I am befuddled by this ticket. Most "defects" mentioned do not exist and have not for some time. Others were handled in the latest commit.

Please re-test ga_init in version 1207 and review.

comment:2 Changed 8 years ago by gegorbet

  • Status changed from new to assigned

Actual needed fix is to allow a single bucket to be saved.

This fix and a few other calculation/GUI fixes have been made and committed.

Once again review-ready.

comment:3 Changed 8 years ago by dzollars

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.