Opened 8 years ago

Closed 8 years ago

#309 closed defect (fixed)

Model description not working correctly

Reported by: dzollars Owned by: dzollars
Priority: normal Milestone: future
Component: ultrascan3 Version:
Keywords: review Cc:

Description

The runID can contain up to 80 characters. The model description field contains the entire runID, but also other characters, and also is limited to 80 characters. Additionally, users can change the runID and the name of the edit profile, which can result in non-standard file names.

Change us_convert, where the runID is assigned, so that non-standard characters cannot be used. Same with us_edit. Also, increase the size of the model description field in the model table.

Change History (4)

comment:1 Changed 8 years ago by dzollars

  • Status changed from new to assigned

Us_convert and us_edit already handle the issue of non-standard characters in the runID and the editID. However, there is no limitation on length for the editID. What is stored in the database is the edit profile filename, and that can be up to 255 characters. Should we impose a length limitation on the editID portion of the filename?

The model description field has been increased in all instances.

comment:2 Changed 8 years ago by dzollars

  • Keywords review added

comment:3 Changed 8 years ago by demeler

I propose to limit the edit field to no more than 25 characters and include this count in the database field length.

comment:4 Changed 8 years ago by dzollars

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.