Opened 8 years ago

Closed 8 years ago

#306 closed defect (fixed)

FE Match saves are not visible in report manager

Reported by: demeler Owned by: gegorbet
Priority: normal Milestone: future
Component: ultrascan3 Version:
Keywords: review Cc:

Description

GA, 2DSA and MC results when saved in us_fematch model viewer should be available as separate report items in the report manager.

Attachments (4)

report.png (44.4 KB) - added by demeler 8 years ago.
save.png (17.6 KB) - added by demeler 8 years ago.
report2.png (27.7 KB) - added by demeler 8 years ago.
report3.png (69.4 KB) - added by demeler 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 follow-up: Changed 8 years ago by gegorbet

  • Keywords review added

A recent commit of etc/reports.xml makes the saves from fematch visible in the report manager.

comment:2 in reply to: ↑ 1 Changed 8 years ago by demeler

Replying to gegorbet:

A recent commit of etc/reports.xml makes the saves from fematch visible in the report manager.

This seems to work partially now. There are still a couple of issues:

  1. not all saved plots/data items are actually accessible in the report. For example, in a recent test the fematch program saved 14 graph items. In the report only 3 plot items were available (see attached screenshots)
  1. The item called "Equilibrium Fit Analysis" is actually the data from a fit meniscus (RMSD vs meniscus position). It has nothing to do with equilibrium. It should be called "Meniscus Fit Results".
  1. in the analysis report for all 2DSA, GA, GA-MC, etc. analysis types I would like to also see the uncorrected values for s and D (without temperature and buffer corrections, i.e., the experimental space values).
  1. I didn't test this, but if the vbar is varied, will the f/f0 be listed somewhere, and then vbar show up in the f/f0 column (of course, labeled vbar)?

Changed 8 years ago by demeler

Changed 8 years ago by demeler

comment:3 follow-up: Changed 8 years ago by demeler

Another issue I noticed: If multiple triples are analyzed for a run and the results are saved in fematch, then for some reason only the first triple shows up in the report, the other triples are empty, even though the reports directory contains the necessary files (see attached images files report2/3.png).

comment:4 in reply to: ↑ 3 Changed 8 years ago by demeler

Replying to demeler:

Another issue I noticed: If multiple triples are analyzed for a run and the results are saved in fematch, then for some reason only the first triple shows up in the report, the other triples are empty, even though the reports directory contains the necessary files (see attached images files report2/3.png).

I should mention this is run demo_intensity2 in the DEMO database.

Changed 8 years ago by demeler

Changed 8 years ago by demeler

comment:5 Changed 8 years ago by gegorbet

The latest commit handles the reported defects. Note that recent changes make previous fematch report outputs invalid ("fem_" reports no longer detected in reporter). All triples show up if reports have been generated recently.

Again review-ready.

comment:6 Changed 8 years ago by dzollars

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.