Opened 9 years ago

Closed 8 years ago

#297 closed defect (fixed)

Make MW editable in Analyte dialog

Reported by: dzollars Owned by: gegorbet
Priority: normal Milestone: future
Component: ultrascan3 Version:
Keywords: review Cc:

Description

While the molecular weight value is not used in any calculation, it should be editable so that the value can be overridden from the automatic calculation. This is mainly a usability issue.

Change History (4)

comment:1 Changed 8 years ago by gegorbet

  • Keywords review added

Molecular Weight is now editable. There has also been verification code added. When a new analyte is given a description and saved, it becomes the selected analyte in the list.

The ability to give a Molecular Weight value when no sequences have been input (so MW=0.0) is important when common vbar is calculated from Solutions.

Review-ready.

comment:2 follow-up: Changed 8 years ago by demeler

  • Keywords additional error found during added

I reviewed this ticket, and found an error: When the calculated MW from sequence is overridden, and the analyte is saved, the program asks the user to confirm using the manually entered value. This is fine. But if OK'ed, the overridden value is not saved, instead, the calculated value is offered the next time the analyte is called up. This was tested under "Protein".

comment:3 in reply to: ↑ 2 Changed 8 years ago by gegorbet

  • Keywords additional error found during removed

Replying to demeler:

I reviewed this ticket, and found an error: When the calculated MW from sequence is overridden, and the analyte is saved, the program asks the user to confirm using the manually entered value. This is fine. But if OK'ed, the overridden value is not saved, instead, the calculated value is offered the next time the analyte is called up. This was tested under "Protein".

Recent fixes correct the code so that a manually entered value is saved. Again, review-ready.

comment:4 Changed 8 years ago by demeler

  • Resolution set to fixed
  • Status changed from new to closed

Reviewed, works now. Ticket will be closed.

Note: See TracTickets for help on using tickets.