Opened 9 years ago

Closed 8 years ago

#291 closed defect (fixed)

2DSA-MC model is amplified

Reported by: dhalling Owned by: gegorbet
Priority: normal Milestone: future
Component: ultrascan3 Version: 1.0
Keywords: review Cc:

Description

I submitted a few jobs to the Alamo cluster for 2DSA-MC analysis. Each was already associated with TI and RI noise files (no noise fitting was performed). 50 MC iterations was chosen. No other option was selected. All the results came back with the model having the right basic shape, but the modeled signal is extremely high and the raw data signal is roughly 50-60 fold smaller. The model's signal is still large if the model is loaded without the noise in the FE model viewer.

Change History (4)

comment:1 Changed 9 years ago by demeler

  • Owner changed from bdubbs to gegorbet

This sounds like improper scaling by the finite element viewer us_fematch. What needs to happen is the following:

Each Monte Carlo iteration results in one model that should match the experimental data perfectly, i.e., each iteration model is on the same scale as the experimental data. When you display multiple Monte Carlo iterations, us_fematch must keep track of the number of models included in the display, add all solutes from all models together, and divide each solute's concentration by the number of models. Furthermore, to accelerate calculation, concentrations from identical solutes should be combined into a single solute, so this solute doesn't need to be simulated multiple times. This should happen before the astfem simulation. By dividing the concentration of each remaining solute by the number of models included, the sum will be scaled again properly for the fematch display.

comment:2 Changed 8 years ago by gegorbet

  • Keywords review added

Proper scaling of a composite MC model has been enacted.

This ticket is review-ready.

comment:3 Changed 8 years ago by gegorbet

  • Status changed from new to assigned

comment:4 Changed 8 years ago by dzollars

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.