Opened 10 years ago

Closed 10 years ago

#1 closed defect (fixed)

Complete Model Editor

Reported by: bdubbs Owned by: bdubbs
Priority: normal Milestone: alpha
Component: ultrascan3 Version:
Keywords: Cc:

Description

Finish Associations for Model Editor
Review Code

Change History (8)

comment:1 Changed 10 years ago by bdubbs

  • Status changed from new to assigned

comment:2 Changed 10 years ago by bdubbs

#1 Demo

comment:3 follow-ups: Changed 10 years ago by demeler

First review comments:

us_analyte:

  • "more info" doesn't work
  • clear fields when switching between "use DB" and "use local disk"
  • just call reset function when switching between "use DB" and "use local disk"
  • doesn't accept name entered under "Analyte Description"
  • new button: New analyte (don't reset, set flag to check user has saved before proceeding)
  • replace "Save Analyte" with "New Analyte", replace "Update Analyte" with "Save Analyte"
  • handle active/inactive status
  • add enterPressed signal to analyte selection

us_investigator:

  • filter on partial strings for both first and last name

us_predict1:

  • use 6 significant digits and centipoise

Set Analyte Properties (us_properties)

  • analyte concentration should not change model
  • numbers should be consistently displayed with the same # of significant digits
  • check logic on changing extinction coefficients, vbar, MW, etc.
  • check cosedimenting solute logic for more than 1 solutes.
  • calculations need to be done with poise units.

comment:4 Changed 10 years ago by bdubbs

  • Type changed from enhancement to defect

us_investigator portion fixed at revision 368.

comment:5 in reply to: ↑ 3 ; follow-up: Changed 10 years ago by bdubbs

Replying to demeler:

us_analyte:

  • clear fields when switching between "use DB" and "use local disk"
  • just call reset function when switching between "use DB" and "use local disk"

Do you really want to do this? There is no way to copy an analyte between disk and DB. If we just leave things alone when changing DB/Disk, we can read an analyte, change DB/Disk, and save. If switching DB/Disk resets all fields, the analyte needs to be recreated for the opposite storage.

  • add enterPressed signal to analyte selection

What is this again? Keyboard? There are no keyboard functions in QListWidget, but I may be able set up a custom keyboard event.

comment:6 in reply to: ↑ 5 Changed 10 years ago by demeler

Replying to bdubbs:

Replying to demeler:

us_analyte:

  • clear fields when switching between "use DB" and "use local disk"
  • just call reset function when switching between "use DB" and "use local disk"

Do you really want to do this? There is no way to copy an analyte between disk and DB. If we just leave things alone when changing DB/Disk, we can read an analyte, change DB/Disk, and save. If switching DB/Disk resets all fields, the analyte needs to be recreated for the opposite storage.

Good point, let's not reset.

  • add enterPressed signal to analyte selection

What is this again? Keyboard? There are no keyboard functions in QListWidget, but I may be able set up a custom keyboard event.

I don't recall. Let me know when you have finished the list of repairs and we'll go over it again.
-b.

comment:7 in reply to: ↑ 3 Changed 10 years ago by bdubbs

Replying to demeler:

First review comments:

us_analyte:

  • "more info" doesn't work
  • clear fields when switching between "use DB" and "use local disk"
  • just call reset function when switching between "use DB" and "use local disk"
  • doesn't accept name entered under "Analyte Description"
  • new button: New analyte (don't reset, set flag to check user has saved before proceeding)
  • replace "Save Analyte" with "New Analyte", replace "Update Analyte" with "Save Analyte"
  • handle active/inactive status
  • add enterPressed signal to analyte selection

Fixed all but 2, 3, and 8. Let's go over this when you get a chance. Updated on bcf:5.

us_investigator:

  • filter on partial strings for both first and last name

Fixed.

us_predict1:

  • use 6 significant digits and centipoise

Fixed.

Still need to work on us_properties. In the future, it would probably be best to have a separate ticket for each module.

comment:8 Changed 10 years ago by bdubbs

  • Resolution set to fixed
  • Status changed from assigned to closed

Moved analyte properties to #4. The rest of the issues are fixed.

Note: See TracTickets for help on using tickets.